netdev - Re: [PATCH ipsec-next] xfrm: state: make xfrm_state_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9T37SEkcgN/3U9L@gauss3.secunet.de>
Date: Sat, 15 Mar 2025 04:45:49 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Florian Westphal <fw@...len.de>
CC: <netdev@...r.kernel.org>, <herbert@...dor.apana.org.au>,
	<davem@...emloft.net>
Subject: Re: [PATCH ipsec-next] xfrm: state: make xfrm_state_lookup_byaddr
 lockless

On Fri, Mar 07, 2025 at 12:47:54PM +0100, Florian Westphal wrote:
> This appears to be an oversight back when the state lookup
> was converted to RCU, I see no reason why we need to hold the
> state lock here.
> 
> __xfrm_state_lookup_byaddr already uses xfrm_state_hold_rcu
> helper to obtain a reference, so just replace the state
> lock with rcu.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks Florian!