netdev - Re: [PATCH] xfrm: ipcomp: Call pskb_may_pull in ipcomp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9T3V/M0hXIiHsLB@gauss3.secunet.de>
Date: Sat, 15 Mar 2025 04:43:19 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: <netdev@...r.kernel.org>
Subject: Re: [PATCH] xfrm: ipcomp: Call pskb_may_pull in ipcomp_input

On Thu, Mar 13, 2025 at 04:11:13PM +0800, Herbert Xu wrote:
> If a malformed packet is received there may not be enough data
> to pull.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> ---
>  net/xfrm/xfrm_ipcomp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/xfrm/xfrm_ipcomp.c b/net/xfrm/xfrm_ipcomp.c
> index 9c0fa0e1786a..43eae94e4b0e 100644
> --- a/net/xfrm/xfrm_ipcomp.c
> +++ b/net/xfrm/xfrm_ipcomp.c
> @@ -97,6 +97,9 @@ int ipcomp_input(struct xfrm_state *x, struct sk_buff *skb)
>  	int err = -ENOMEM;
>  	struct ip_comp_hdr *ipch;
>  
> +	if (!pskb_may_pull(skb, sizeof(*ipch)))
> +		return -EINVAL;
> +

This looks like fix, right?

Can you add a Fixes tag so it can be backported?