netdev - RE: [Intel-wired-lan] [iwl-net v3 4/5] ice: fix input validation for virtchnl BW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58654D6A7569A251E4249A058FDF2@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Mon, 17 Mar 2025 13:27:37 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Czapnik, Lukasz"
	<lukasz.czapnik@...el.com>, "Jagielski, Jedrzej"
	<jedrzej.jagielski@...el.com>, Simon Horman <horms@...nel.org>
Subject: RE: [Intel-wired-lan] [iwl-net v3 4/5] ice: fix input validation for
 virtchnl BW

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Martyna Szapar-Mudlaw
> Sent: Tuesday, March 4, 2025 12:09 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Czapnik, Lukasz <lukasz.czapnik@...el.com>;
> Jagielski, Jedrzej <jedrzej.jagielski@...el.com>; Simon Horman
> <horms@...nel.org>; Martyna Szapar-Mudlaw <martyna.szapar-
> mudlaw@...ux.intel.com>
> Subject: [Intel-wired-lan] [iwl-net v3 4/5] ice: fix input validation for virtchnl BW
> 
> From: Lukasz Czapnik <lukasz.czapnik@...el.com>
> 
> Add missing validation of tc and queue id values sent by a VF in
> ice_vc_cfg_q_bw().
> Additionally fixed logged value in the warning message, where max_tx_rate was
> incorrectly referenced instead of min_tx_rate.
> Also correct error handling in this function by properly exiting when invalid
> configuration is detected.
> 
> Fixes: 015307754a19 ("ice: Support VF queue rate limit and quanta size
> configuration")
> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Lukasz Czapnik <lukasz.czapnik@...el.com>
> Co-developed-by: Martyna Szapar-Mudlaw <martyna.szapar-
> mudlaw@...ux.intel.com>
> Signed-off-by: Martyna Szapar-Mudlaw <martyna.szapar-
> mudlaw@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_virtchnl.c | 24 ++++++++++++++++---
>  1 file changed, 21 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> index adb1bf12542f..824ef849b0ea 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> @@ -1865,15 +1865,33 @@ static int ice_vc_cfg_q_bw(struct ice_vf *vf, u8

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>