netdev - RE: [Intel-wired-lan] [iwl-net v3 3/5] ice: validate queue quanta parameters to prevent OOB access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB586553D8C05A600B42D33AF38FDF2@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Mon, 17 Mar 2025 13:28:07 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Glaza, Jan"
	<jan.glaza@...el.com>, "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>,
	Simon Horman <horms@...nel.org>
Subject: RE: [Intel-wired-lan] [iwl-net v3 3/5] ice: validate queue quanta
 parameters to prevent OOB access

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Martyna Szapar-Mudlaw
> Sent: Tuesday, March 4, 2025 12:09 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Glaza, Jan <jan.glaza@...el.com>; Jagielski, Jedrzej
> <jedrzej.jagielski@...el.com>; Simon Horman <horms@...nel.org>; Martyna
> Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>
> Subject: [Intel-wired-lan] [iwl-net v3 3/5] ice: validate queue quanta parameters
> to prevent OOB access
> 
> From: Jan Glaza <jan.glaza@...el.com>
> 
> Add queue wraparound prevention in quanta configuration.
> Ensure end_qid does not overflow by validating start_qid and num_queues.
> 
> Fixes: 015307754a19 ("ice: Support VF queue rate limit and quanta size
> configuration")
> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Jan Glaza <jan.glaza@...el.com>
> Signed-off-by: Martyna Szapar-Mudlaw <martyna.szapar-
> mudlaw@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_virtchnl.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> index 343f2b4b0dc5..adb1bf12542f 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> @@ -1903,13 +1903,21 @@ static int ice_vc_cfg_q_bw(struct ice_vf *vf, u8

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>