netdev - Re: [PATCH net-next] ethtool: Block setting of symmetric RSS when non-symmetric rx-flow-hash is requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4217b36d-7999-4c4a-8244-856992bf3d69@nvidia.com>
Date: Tue, 18 Mar 2025 09:26:18 +0200
From: Gal Pressman <gal@...dia.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next] ethtool: Block setting of symmetric RSS when
 non-symmetric rx-flow-hash is requested

On 17/03/2025 17:07, Simon Horman wrote:
> On Mon, Mar 10, 2025 at 09:23:29AM +0200, Gal Pressman wrote:
>> Symmetric RSS hash requires that:
>> * No other fields besides IP src/dst and/or L4 src/dst
> 
> nit: I think it would read slightly better if the line above included a verb.
>      Likewise for the code comment with the same text.
> 
>> * If src is set, dst must also be set
>>
>> This restriction was only enforced when RXNFC was configured after
>> symmetric hash was enabled. In the opposite order of operations (RXNFC
>> then symmetric enablement) the check was not performed.
>>
>> Perform the sanity check on set_rxfh as well, by iterating over all flow
>> types hash fields and making sure they are all symmetric.
>>
>> Introduce a function that returns whether a flow type is hashable (not
>> spec only) and needs to be iterated over. To make sure that no one
>> forgets to update the list of hashable flow types when adding new flow
>> types, a static assert is added to draw the developer's attention.
>>
>> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
>> Signed-off-by: Gal Pressman <gal@...dia.com>
> 
> The nit above not withstanding - take it or leave it - this looks good to me.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Will change, thanks for the review.