netdev - Re: [PATCH net-next] ethtool: Block setting of symmetric RSS when non-symmetric rx-flow-hash is requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9461675d-3385-4948-83a5-de34e0605b10@nvidia.com>
Date: Tue, 18 Mar 2025 09:28:57 +0200
From: Gal Pressman <gal@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next] ethtool: Block setting of symmetric RSS when
 non-symmetric rx-flow-hash is requested

On 17/03/2025 22:19, Paolo Abeni wrote:
> I fear we can't replace macros with enum in uAPI: existing application
> could do weird thing leveraging the macro defintion and would break with
> this change.

I couldn't think of any issues, you got me curious, do you have an example?

> 
> I think you could simply add:
> 
> #define FLOW_TYPE_MAX 0x1f

I preferred the enum so it would be "automatic", anyway, will change,
thanks!