[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9af06d0b-8b3b-4353-8cc7-65ec50bf4edb@redhat.com>
Date: Tue, 18 Mar 2025 08:36:55 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Gal Pressman <gal@...dia.com>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next] ethtool: Block setting of symmetric RSS when
non-symmetric rx-flow-hash is requested
On 3/18/25 8:28 AM, Gal Pressman wrote:
> On 17/03/2025 22:19, Paolo Abeni wrote:
>> I fear we can't replace macros with enum in uAPI: existing application
>> could do weird thing leveraging the macro defintion and would break with
>> this change.
>
> I couldn't think of any issues, you got me curious, do you have an example?
I guess something alike the following could be quite common or at least
possible:
#ifdef AH_V4_FLOW
// kernel support AH flow, implement user-space side
#else
// fail on any AH-flow related code path
#endif
Cheers,
Paolo
Powered by blists - more mailing lists