netdev - Re: [PATCH net-next] ethtool: Block setting of symmetric RSS when non-symmetric rx-flow-hash is requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb3badef-2603-4bab-8d7a-c3a90c28dc64@nvidia.com>
Date: Tue, 18 Mar 2025 11:00:10 +0200
From: Gal Pressman <gal@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next] ethtool: Block setting of symmetric RSS when
 non-symmetric rx-flow-hash is requested

On 18/03/2025 9:36, Paolo Abeni wrote:
> On 3/18/25 8:28 AM, Gal Pressman wrote:
>> On 17/03/2025 22:19, Paolo Abeni wrote:
>>> I fear we can't replace macros with enum in uAPI: existing application
>>> could do weird thing leveraging the macro defintion and would break with
>>> this change.
>>
>> I couldn't think of any issues, you got me curious, do you have an example?
> 
> I guess something alike the following could be quite common or at least
> possible:
> 
> #ifdef AH_V4_FLOW
> 
> // kernel support AH flow, implement user-space side
> 
> #else
> 
> // fail on any AH-flow related code path
> 
> #endif

Right, thanks Paolo!