netdev - Re: [PATCH net-next v8 14/14] xsc: add ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2fe60393-494a-4708-b1a3-559b647c6ce7@yunsilicon.com>
Date: Tue, 18 Mar 2025 17:00:19 +0800
From: "Xin Tian" <tianx@...silicon.com>
To: "Paolo Abeni" <pabeni@...hat.com>, <netdev@...r.kernel.org>
Cc: <leon@...nel.org>, <andrew+netdev@...n.ch>, <kuba@...nel.org>, 
	<edumazet@...gle.com>, <davem@...emloft.net>, 
	<jeff.johnson@....qualcomm.com>, <przemyslaw.kitszel@...el.com>, 
	<weihg@...silicon.com>, <wanry@...silicon.com>, <jacky@...silicon.com>, 
	<horms@...nel.org>, <parthiban.veerasooran@...rochip.com>, 
	<masahiroy@...nel.org>, <kalesh-anakkur.purayil@...adcom.com>, 
	<geert+renesas@...der.be>
Subject: Re: [PATCH net-next v8 14/14] xsc: add ndo_get_stats64

On 2025/3/12 17:37, Xin Tian wrote:
> On 2025/3/11 23:28, Paolo Abeni wrote:
>> On 3/7/25 11:08 AM, Xin Tian wrote:
>>> +void xsc_eth_fold_sw_stats64(struct xsc_adapter *adapter,
>>> +			     struct rtnl_link_stats64 *s)
>>> +{
>>> +	int i, j;
>>> +
>>> +	for (i = 0; i < xsc_get_netdev_max_channels(adapter); i++) {
>>> +		struct xsc_channel_stats *channel_stats;
>>> +		struct xsc_rq_stats *rq_stats;
>>> +
>>> +		channel_stats = &adapter->stats->channel_stats[i];
>>> +		rq_stats = &channel_stats->rq;
>>> +
>>> +		s->rx_packets   += rq_stats->packets;
>>> +		s->rx_bytes     += rq_stats->bytes;
>> This likely needs a u64_stats_fetch_begin/u64_stats_fetch_retry() pair,
>> and u64_stats_update_begin()/end() on the write side.
>>
>> /P
> Good suggestion, I will change it.

Sorry Paolo, I was mistaken earlier.

I confirmed that our device only supports 64-bit architectures, x86_64 
and ARM64, so this is not needed.

Thanks,

Xin