netdev - Re: [PATCH net-next v8 09/14] xsc: Init net device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c78dc4e0-a5c6-44ca-b84e-6b23956b71f4@yunsilicon.com>
Date: Tue, 18 Mar 2025 12:29:54 +0800
From: "Xin Tian" <tianx@...silicon.com>
To: "Paolo Abeni" <pabeni@...hat.com>, <netdev@...r.kernel.org>
Cc: <leon@...nel.org>, <andrew+netdev@...n.ch>, <kuba@...nel.org>, 
	<edumazet@...gle.com>, <davem@...emloft.net>, 
	<jeff.johnson@....qualcomm.com>, <przemyslaw.kitszel@...el.com>, 
	<weihg@...silicon.com>, <wanry@...silicon.com>, <jacky@...silicon.com>, 
	<horms@...nel.org>, <parthiban.veerasooran@...rochip.com>, 
	<masahiroy@...nel.org>, <kalesh-anakkur.purayil@...adcom.com>, 
	<geert+renesas@...der.be>
Subject: Re: [PATCH net-next v8 09/14] xsc: Init net device

On 2025/3/11 23:12, Paolo Abeni wrote:
> On 3/7/25 11:08 AM, Xin Tian wrote:
>>   struct xsc_adapter {
>>   	struct net_device	*netdev;
>>   	struct pci_dev		*pdev;
>>   	struct device		*dev;
>>   	struct xsc_core_device	*xdev;
>> +
>> +	struct xsc_eth_params	nic_param;
>> +	struct xsc_rss_params	rss_param;
>> +
>> +	struct workqueue_struct		*workq;
>> +
>> +	struct xsc_sq		**txq2sq;
>> +
>> +	u32	status;
>> +	struct mutex	status_lock; /*protect status */
> You should consider using dev->lock instead.
>
> /P

This |dev| refers to the PCI device and will be used by several drivers. 
So using |dev->lock| may not be a better choice.


Thanks,

Xin