netdev - RE: [Intel-wired-lan] [PATCH iwl-net v3] ixgbe: fix media type detection for E610 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH8PR11MB7965E1CA038EEEBFBABF46BBF7DE2@PH8PR11MB7965.namprd11.prod.outlook.com>
Date: Tue, 18 Mar 2025 04:34:00 +0000
From: "R, Bharath" <bharath.r@...el.com>
To: "Kwapulinski, Piotr" <piotr.kwapulinski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "pmenzel@...gen.mpg.de"
	<pmenzel@...gen.mpg.de>, "andrew@...n.ch" <andrew@...n.ch>, "Kwapulinski,
 Piotr" <piotr.kwapulinski@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v3] ixgbe: fix media type
 detection for E610 device

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Piotr Kwapulinski
> Sent: Friday, February 21, 2025 9:19 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; pmenzel@...gen.mpg.de; andrew@...n.ch;
> Kwapulinski, Piotr <piotr.kwapulinski@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v3] ixgbe: fix media type detection
> for E610 device
> 
> The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610
> device") introduced incorrect media type detection for E610 device. It
> reproduces when advertised speed is modified after driver reload. Clear the
> previous outdated PHY type high value.
> 
> Reproduction steps:
> modprobe ixgbe
> ethtool -s eth0 advertise 0x1000000000000 modprobe -r ixgbe modprobe
> ixgbe ethtool -s eth0 advertise 0x1000000000000 Result before the fix:
> netlink error: link settings update failed netlink error: Invalid argument Result
> after the fix:
> No output error
> 
> Fixes: 23c0e5a16bcc ("ixgbe: Add link management support for E610 device")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
> ---
> v1 -> v2
>   More commit message details and reproduction steps added
> v2 -> v3
>   More details in reproduction steps added
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Tested-by: Bharath R <bharath.r@...el.com>