netdev - RE: [PATCH v2 net-next 00/15] AccECN protocol patch series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR07MB7984CE4C9F8930870712D7F6A3DE2@PAXPR07MB7984.eurprd07.prod.outlook.com>
Date: Tue, 18 Mar 2025 10:28:04 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Eric Dumazet <edumazet@...gle.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "dave.taht@...il.com"
	<dave.taht@...il.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"jhs@...atatu.com" <jhs@...atatu.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>,
	"horms@...nel.org" <horms@...nel.org>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"ast@...erby.net" <ast@...erby.net>, "liuhangbin@...il.com"
	<liuhangbin@...il.com>, "shuah@...nel.org" <shuah@...nel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"ij@...nel.org" <ij@...nel.org>, "ncardwell@...gle.com"
	<ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, g.white <g.white@...lelabs.com>,
	"ingemar.s.johansson@...csson.com" <ingemar.s.johansson@...csson.com>,
	"mirja.kuehlewind@...csson.com" <mirja.kuehlewind@...csson.com>,
	"cheshire@...le.com" <cheshire@...le.com>, "rs.ietf@....at" <rs.ietf@....at>,
	"Jason_Livingood@...cast.com" <Jason_Livingood@...cast.com>, vidhi_goel
	<vidhi_goel@...le.com>
Subject: RE: [PATCH v2 net-next 00/15] AccECN protocol patch series

Please see below.

> On Tue, Mar 18, 2025 at 1:27 AM <chia-yu.chang@...ia-bell-labs.com> wrote:
> >
> > From: Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
> >
> > Hello,
> >
> > Plese find v2:
> >
> > v2 (18-03-2025)
> > - Add one missing patch from previous AccECN protocol preparation patch series to this patch series
> >
> > The full patch series can be found in
> > https://github.com/L4STeam/linux-net-next/commits/upstream_l4steam/
> >
> > The Accurate ECN draft can be found in
> > https://datatracker.ietf.org/doc/html/draft-ietf-tcpm-accurate-ecn-28
> >
> > Best regards,
> > Chia-Yu
> >
> > Chia-Yu Chang (1):
> >   tcp: accecn: AccECN option failure handling
>
>
> I do not see any tests, how can this be tested ?
>
> I am extremely worried.

Thanks for the feedback.

And I would do the packetdrill AccECN tests (https://github.com/minuscat/packetdrill_accecn/tree/main/gtests/net/tcp/accecn) to verify it.

I've tested the latest net-next (6.14-rc6 commit 702e3fa16cd42ba712825e8d6171ea4755bc0491) with all 41 AccECN patches (11 patches are in net-next and 30 patches will be submitted series-by-series).

All 189 cases are passed, does this look ok for you?