netdev - RE: [PATCH iwl-next v2 1/3] ice: remove SW side band access workaround for E825

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB62195CF656933B53CE11BB6A92DE2@IA1PR11MB6219.namprd11.prod.outlook.com>
Date: Tue, 18 Mar 2025 14:00:50 +0000
From: "Nitka, Grzegorz" <grzegorz.nitka@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [PATCH iwl-next v2 1/3] ice: remove SW side band access
 workaround for E825

> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Monday, March 17, 2025 5:36 PM
> To: Nitka, Grzegorz <grzegorz.nitka@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Kolacinski,
> Karol <karol.kolacinski@...el.com>; Michal Swiatkowski
> <michal.swiatkowski@...ux.intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: Re: [PATCH iwl-next v2 1/3] ice: remove SW side band access
> workaround for E825
> 
> On Mon, Mar 10, 2025 at 01:24:37PM +0100, Grzegorz Nitka wrote:
> > From: Karol Kolacinski <karol.kolacinski@...el.com>
> >
> > Due to the bug in FW/NVM autoload mechanism (wrong default
> > SB_REM_DEV_CTL register settings), the access to peer PHY and CGU
> > clients was disabled by default.
> >
> > As the workaround solution, the register value was overwritten by the
> > driver at the probe or reset handling.
> > Remove workaround as it's not needed anymore. The fix in autoload
> > procedure has been provided with NVM 3.80 version.
> 
> Hi Grzegorz,
> 
> As per my belated comment on v2 [*], I think it would be worth adding
> a brief comment here regarding this not being expected to cause
> a regression in HW+FW seen in the wild.
> 
> [*] https://lore.kernel.org/netdev/20250317163359.GC688833@kernel.org/
> 

Thanks Simon for your feedback.
Sure, I'll address it in next version.

Kind Regards

Grzegorz

> >
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> > Signed-off-by: Grzegorz Nitka <grzegorz.nitka@...el.com>
> 
> ...