netdev - Re: [PATCH v1 net-next 1/4] af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9rpSFrBxOfIVRNb@LQ3V64L9R2>
Date: Wed, 19 Mar 2025 08:56:56 -0700
From: Joe Damato <jdamato@...tly.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, edumazet@...gle.com, horms@...nel.org,
	kuba@...nel.org, kuni1840@...il.com, netdev@...r.kernel.org,
	pabeni@...hat.com
Subject: Re: [PATCH v1 net-next 1/4] af_unix: Sort headers.

On Tue, Mar 18, 2025 at 04:50:00PM -0700, Kuniyuki Iwashima wrote:
> From: Joe Damato <jdamato@...tly.com>
> Date: Tue, 18 Mar 2025 16:07:47 -0700
> > > +#include <linux/in.h>
> > >  #include <linux/init.h>
> > > +#include <linux/kernel.h>
> > > +#include <linux/module.h>
> > > +#include <linux/mount.h>
> > > +#include <linux/namei.h>
> > > +#include <linux/net.h>
> > > +#include <linux/netdevice.h>
> > >  #include <linux/poll.h>
> > > +#include <linux/proc_fs.h>
> > >  #include <linux/rtnetlink.h>
> > > -#include <linux/mount.h>
> > > -#include <net/checksum.h>
> > > +#include <linux/sched/signal.h>
> > 
> > Not sure what the sorting rules are, but I was wondering if maybe
> > "linux/sched/*.h" should come after linux/*.h and not sorted within
> > linux/s*.h ?
> 
> It's simply sorted in the alphabetial order.

Yea, I understand that - just wasn't sure if subdirectories should
be sorted separately.
 
> Actually I haven't cared about the / level, so I grepped the
> linux/sched/signal.h users and it looks like most didn't care.
> 
>   grep -rnI --include=*.c --include=*.h "linux/sched/signal.h" -C 3

OK, fair enough.

Reviewed-by: Joe Damato <jdamato@...tly.com>