netdev - Re: [PATCH v1 net-next 2/4] af_unix: Move internal definitions to net/unix/.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67db03aba87a1_1367b29420@willemb.c.googlers.com.notmuch>
Date: Wed, 19 Mar 2025 13:49:31 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>, 
 Kuniyuki Iwashima <kuni1840@...il.com>, 
 netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 2/4] af_unix: Move internal definitions to
 net/unix/.

Kuniyuki Iwashima wrote:
> net/af_unix.h is included by core and some LSMs, but most definitions
> need not be.
> 
> Let's move struct unix_{vertex,edge} to net/unix/garbage.c and other
> definitions to net/unix/af_unix.h.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

One trade-off with these kinds of refactors is that it adds an
indirection in git history: a git blame on a line no longer points to
the relevant commit.

Whether the trade-off is worth it is subjective, your call. Just
making it explicit.

I still manually check out pre UDP/UDPLite split often to go back in
udp history, for instance.