netdev - RE: [net-next PATCH] net: phylink: Remove unused function pointer from phylink structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB50898DAAAFB98B401BBBB7D5D6D92@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Wed, 19 Mar 2025 19:08:30 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Alexander Duyck <alexander.duyck@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "linux@...linux.org.uk" <linux@...linux.org.uk>, "andrew@...n.ch"
	<andrew@...n.ch>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
Subject: RE: [net-next PATCH] net: phylink: Remove unused function pointer
 from phylink structure



> -----Original Message-----
> From: Alexander Duyck <alexander.duyck@...il.com>
> Sent: Wednesday, March 19, 2025 10:46 AM
> To: netdev@...r.kernel.org
> Cc: linux@...linux.org.uk; andrew@...n.ch; hkallweit1@...il.com;
> davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com
> Subject: [net-next PATCH] net: phylink: Remove unused function pointer from
> phylink structure
> 
> From: Alexander Duyck <alexanderduyck@...com>
> 
> From what I can tell the get_fixed_state pointer in the phylink structure
> hasn't been used since commit <5c05c1dbb177> ("net: phylink, dsa: eliminate
> phylink_fixed_state_cb()") . Since I can't find any users for it we might
> as well just drop the pointer.
> 
> Fixes: 5c05c1dbb177 ("net: phylink, dsa: eliminate phylink_fixed_state_cb()")
> Signed-off-by: Alexander Duyck <alexanderduyck@...com>
> ---
>  drivers/net/phy/phylink.c |    2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 0f70a7f3dfcc..16a1f31f0091 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -72,8 +72,6 @@ struct phylink {
>  	struct gpio_desc *link_gpio;
>  	unsigned int link_irq;
>  	struct timer_list link_poll;
> -	void (*get_fixed_state)(struct net_device *dev,
> -				struct phylink_link_state *s);
> 
>  	struct mutex state_mutex;
>  	struct phylink_link_state phy_state;
> 
>