netdev - Re: [net-next PATCH] net: phylink: Remove unused function pointer from phylink structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9scLKGWBoEwVA66@shell.armlinux.org.uk>
Date: Wed, 19 Mar 2025 19:34:04 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Alexander Duyck <alexander.duyck@...il.com>
Cc: netdev@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
	davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [net-next PATCH] net: phylink: Remove unused function pointer
 from phylink structure

On Wed, Mar 19, 2025 at 10:46:25AM -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@...com>
> 
> From what I can tell the get_fixed_state pointer in the phylink structure
> hasn't been used since commit <5c05c1dbb177> ("net: phylink, dsa: eliminate
> phylink_fixed_state_cb()") . Since I can't find any users for it we might
> as well just drop the pointer.
> 
> Fixes: 5c05c1dbb177 ("net: phylink, dsa: eliminate phylink_fixed_state_cb()")
> Signed-off-by: Alexander Duyck <alexanderduyck@...com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!