netdev - Re: [PATCH net-next 3/6] mlxsw: spectrum_switchdev: Add an internal API for VXLAN leave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320155826.GF889584@horms.kernel.org>
Date: Thu, 20 Mar 2025 15:58:26 +0000
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	Ido Schimmel <idosch@...dia.com>, Amit Cohen <amcohen@...dia.com>,
	mlxsw@...dia.com
Subject: Re: [PATCH net-next 3/6] mlxsw: spectrum_switchdev: Add an internal
 API for VXLAN leave

On Mon, Mar 17, 2025 at 06:37:28PM +0100, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> There is asymmetry in how the VXLAN join and leave functions are used.
> The join function (mlxsw_sp_bridge_vxlan_join()) is only called in
> response to netdev events (e.g., VXLAN device joining a bridge), but the
> leave function is also called in response to switchdev events (e.g.,
> VLAN configuration on top of the VXLAN device) in order to invalidate
> VNI to FID mappings.
> 
> This asymmetry will cause problems when the functions will be later
> extended to mark VXLAN bridge ports as offloaded or not.
> 
> Therefore, create an internal function (__mlxsw_sp_bridge_vxlan_leave())
> that is used to invalidate VNI to FID mappings and call it from
> mlxsw_sp_bridge_vxlan_leave() which will only be invoked in response to
> netdev events, like mlxsw_sp_bridge_vxlan_join().
> 
> No functional changes intended.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>