netdev - Re: [PATCH net-next 2/6] mlxsw: spectrum: Call mlxsw_sp_bridge_vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320155810.GE889584@horms.kernel.org>
Date: Thu, 20 Mar 2025 15:58:10 +0000
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	Ido Schimmel <idosch@...dia.com>, Amit Cohen <amcohen@...dia.com>,
	mlxsw@...dia.com
Subject: Re: [PATCH net-next 2/6] mlxsw: spectrum: Call
 mlxsw_sp_bridge_vxlan_{join, leave}() for VLAN-aware bridge

On Mon, Mar 17, 2025 at 06:37:27PM +0100, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> mlxsw_sp_bridge_vxlan_{join,leave}() are not called when a VXLAN device
> joins or leaves a VLAN-aware bridge. As mentioned in the comment - when the
> bridge is VLAN-aware, the VNI of the VXLAN device needs to be mapped to a
> VLAN, but at this point no VLANs are configured on the VxLAN device. This
> means that we can call the APIs, but there is no point to do that, as they
> do not configure anything in such cases.
> 
> Next patch will extend mlxsw_sp_bridge_vxlan_{join,leave}() to set hardware
> domain for VXLAN, this should be done also when a VXLAN device joins or
> leaves a VLAN-aware bridge. Call the APIs, which for now do not do anything
> in these flows.
> 
> Align the call to mlxsw_sp_bridge_vxlan_leave() to be called like
> mlxsw_sp_bridge_vxlan_join(), only in case that the VXLAN device is up,
> so move the check to be done before calling
> mlxsw_sp_bridge_vxlan_{join,leave}(). This does not change the existing
> behavior, as there is a similar check inside mlxsw_sp_bridge_vxlan_leave().
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>