netdev - Re: [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320201025.GL892515@horms.kernel.org>
Date: Thu, 20 Mar 2025 20:10:25 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...zon.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk_ack.timeout

On Thu, Mar 20, 2025 at 08:00:29PM +0100, Eric Dumazet wrote:
> On Thu, Mar 20, 2025 at 7:39 PM Simon Horman <horms@...nel.org> wrote:
> >
> > On Tue, Mar 18, 2025 at 03:43:59PM +0000, Eric Dumazet wrote:
> > > icsk->icsk_ack.timeout can be replaced by icsk->csk_delack_timer.expires
> > >
> > > This saves 8 bytes in TCP/DCCP sockets and helps for better cache locality.
> > >
> > > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > > Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> > > ---
> > > v2: rebase after "tcp: cache RTAX_QUICKACK metric in a hot cache line"
> >
> > Hi Eric,
> >
> > I hate to be a bore, but patch 2/2 does seem to apply to net-next.
> 
> Hmm, what is the message you have ?
> 
> It applies fine here.

Ok, there must be something weird going on in my environment.

FTR, I see this:

$ git checkout net-next/main
HEAD is now at 6855b9be9cf7 Merge branch 'mptcp-pm-prep-work-for-new-ops-and-sysctl-knobs'

$ b4 mbox 20250318154359.778438-1-edumazet@...gle.com
Grabbing thread from lore.kernel.org/all/20250318154359.778438-1-edumazet@...gle.com/t.mbox.gz
5 messages in the thread
Saved ./20250318154359.778438-1-edumazet@...gle.com.mbx

$ git am ./20250318154359.778438-1-edumazet@...gle.com.mbx
Applying: tcp/dccp: remove icsk->icsk_ack.timeout
error: corrupt patch at line 31
Patch failed at 0001 tcp/dccp: remove icsk->icsk_ack.timeout
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"