netdev - Re: [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250324123841.58ece0e8@kernel.org>
Date: Mon, 24 Mar 2025 12:38:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Neal Cardwell <ncardwell@...gle.com>, Kuniyuki
 Iwashima <kuniyu@...zon.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk_ack.timeout

On Tue, 18 Mar 2025 15:43:59 +0000 Eric Dumazet wrote:
> diff --git a/include/net/inet_connection_sock.h b/include/net/inet_connection_sock.h
> index 018118da0ce15c5ba5e3b7fcc1b36425794ec9a1..597f2b98dcf565a8512e815d9eae2b521bac7807 100644
> --- a/include/net/inet_connection_sock.h
> +++ b/include/net/inet_connection_sock.h
> @@ -117,7 +117,6 @@ struct inet_connection_sock {
> 				  lrcv_flowlabel:20, /* last received ipv6 flowlabel	   */
> 				  dst_quick_ack:1, /* cache dst RTAX_QUICKACK		   */
> 				  unused:3;
> -		unsigned long	  timeout;	 /* Currently scheduled timeout		   */
> 		__u32		  lrcvtime;	 /* timestamp of last received data packet */
> 		__u16		  last_seg_size; /* Size of last incoming segment	   */
> 		__u16		  rcv_mss;	 /* MSS used for delayed ACK decisions	   */

I get the same errors as Simon, something ate the leading spaces 
in the patch.
-- 
pw-bot: cr