netdev - Re: [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL with HTB parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a60ae0c-0b5f-44e9-8063-29d0d290699c@mojatatu.com>
Date: Sun, 23 Mar 2025 19:48:39 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc: jhs@...atatu.com, jiri@...nulli.us, edumazet@...gle.com,
 gerrard.tai@...rlabs.sg, Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL
 with HTB parent

On 20/03/2025 20:25, Cong Wang wrote:
> Add a test case for CODEL with HTB parent to verify packet drop
> behavior when the queue becomes empty. This helps ensure proper
> notification mechanisms between qdiscs.
> 
> Note this is best-effort, it is hard to play with those parameters
> perfectly to always trigger ->qlen_notify().
> 
> Cc: Pedro Tammela <pctammela@...atatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Cong, can you double check this test?
I ran all of your other tests and they all succeeded, however
this one specifically is always failing:

Test a4bd: Test CODEL with HTB parent - force packet drop with empty queue

All test results:

1..1
not ok 1 a4bd - Test CODEL with HTB parent - force packet drop with 
empty queue
         Could not match regex pattern. Verify command output:
qdisc codel 10: parent 1:10 limit 1p target 9us interval 999us
  Sent 2884 bytes 2 pkt (dropped 0, overlimits 0 requeues 0)
  backlog 0b 0p requeues 0
   count 0 lastcount 0 ldelay 11.5s drop_next 0us
   maxpacket 1442 ecn_mark 0 drop_overlimit 0

cheers,
Victor