netdev - Re: [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL with HTB parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z+cIB3YrShvCtQry@pop-os.localdomain>
Date: Fri, 28 Mar 2025 13:35:19 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: Victor Nogueira <victor@...atatu.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, jiri@...nulli.us,
	edumazet@...gle.com, gerrard.tai@...rlabs.sg,
	Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [Patch net 08/12] selftests/tc-testing: Add a test case for
 CODEL with HTB parent

On Sun, Mar 23, 2025 at 07:48:39PM -0300, Victor Nogueira wrote:
> On 20/03/2025 20:25, Cong Wang wrote:
> > Add a test case for CODEL with HTB parent to verify packet drop
> > behavior when the queue becomes empty. This helps ensure proper
> > notification mechanisms between qdiscs.
> > 
> > Note this is best-effort, it is hard to play with those parameters
> > perfectly to always trigger ->qlen_notify().
> > 
> > Cc: Pedro Tammela <pctammela@...atatu.com>
> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> 
> Cong, can you double check this test?
> I ran all of your other tests and they all succeeded, however
> this one specifically is always failing:

Interesting, I thought I completely fixed this before posting after several
rounds of playing with the parameters. I will double check it, maybe it
just becomes less reproducible.

codel is indeed the hardest one, since fq_codel has a mem limit we can
leverage. (In the worst case, we can drop the codel test case.)

Thanks!