lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87v7rvn2vx.fsf@bootlin.com>
Date: Wed, 26 Mar 2025 18:00:18 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Ramon Fontes <ramonreisfontes@...il.com>
Cc: davem@...emloft.net,  kuba@...nel.org,  pabeni@...hat.com,
  linux-wpan@...r.kernel.org,  alex.aring@...il.com,
  netdev@...r.kernel.org
Subject: Re: [PATCH] mac802154_hwsim: define perm_extended_addr initialization

Hello Ramon,

On 26/03/2025 at 07:34:14 -03, Ramon Fontes <ramonreisfontes@...il.com> wrote:

> Hello Miquèl,
>
> This PR aims to replicate functionality similar to what is implemented
> in mac80211_hwsim
> (https://github.com/torvalds/linux/blob/master/drivers/net/wireless/virtual/mac80211_hwsim.c#L5223).
> This approach is useful for testing wireless medium emulation tools
> like wmediumd (https://github.com/bcopeland/wmediumd/blob/master/tests/)
> and I plan to submit more PRs soon.
>
> I've started developing a wmediumd-like framework for mac802154_hwsim,
> which you can find here:
> https://github.com/ramonfontes/wmediumd_802154. However, it's still in
> its early stages.
>
> Indeed, I'm responsible for Mininet-WiFi
> (https://github.com/intrig-unicamp/mininet-wifi) which supports IEEE
> 802.15.4 emulation via mac802154_hwsim. Having a wireless medium
> emulation for mac802154_hwsim would be highly beneficial, as it
> enables controlled testing and facilitates prototyping.

Okay, I must say I do not know this project, but it looks interesting.
If the others are fine with this change, I'm fine too.

>> Also, please wrap the commit log.
> Apologies for any confusion. Could you clarify if there are any
> specific changes I need to make in the PR?

Yes, just change:

This establishes an initialization method for perm_extended_addr, aligning it with the approach used in mac80211_hwsim.

Into:

This establishes an initialization method for perm_extended_addr,
aligning it with the approach used in mac80211_hwsim.

Thanks,
Miquèl

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ