netdev - Re: [PATCH] mac802154_hwsim: define perm_extended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8U23Z0fpJ7ogsGvdWjnQV7kEwdgEW8pSQwbjT9UPVzn3LXoQ@mail.gmail.com>
Date: Wed, 26 Mar 2025 07:34:14 -0300
From: Ramon Fontes <ramonreisfontes@...il.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	linux-wpan@...r.kernel.org, alex.aring@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] mac802154_hwsim: define perm_extended_addr initialization

Hello Miquèl,

This PR aims to replicate functionality similar to what is implemented
in mac80211_hwsim
(https://github.com/torvalds/linux/blob/master/drivers/net/wireless/virtual/mac80211_hwsim.c#L5223).
This approach is useful for testing wireless medium emulation tools
like wmediumd (https://github.com/bcopeland/wmediumd/blob/master/tests/)
and I plan to submit more PRs soon.

I've started developing a wmediumd-like framework for mac802154_hwsim,
which you can find here:
https://github.com/ramonfontes/wmediumd_802154. However, it's still in
its early stages.

Indeed, I'm responsible for Mininet-WiFi
(https://github.com/intrig-unicamp/mininet-wifi) which supports IEEE
802.15.4 emulation via mac802154_hwsim. Having a wireless medium
emulation for mac802154_hwsim would be highly beneficial, as it
enables controlled testing and facilitates prototyping.

> Also, please wrap the commit log.
Apologies for any confusion. Could you clarify if there are any
specific changes I need to make in the PR?

Em qua., 26 de mar. de 2025 às 07:12, Miquel Raynal
<miquel.raynal@...tlin.com> escreveu:
>
> Hello Ramon,
>
> On 25/03/2025 at 13:53:12 -03, Ramon Fontes <ramonreisfontes@...il.com> wrote:
>
> > This establishes an initialization method for perm_extended_addr, aligning it with the approach used in mac80211_hwsim.
>
> You are now enforcing an (almost) static value, is that the intended
> behaviour? If yes I would like a better explanation of why this is
> relevant and how you picked eg. 0x02 as prefix to justify the change.
>
> In general I am not opposed, even though I kind of liked the idea of
> generating random addresses, especially since hwsim is not the only one
> to do that and having a simulator that behaves like regular device
> drivers actually makes sense IMO.
>
> Also, please wrap the commit log.
>
> > Signed-off-by: Ramon Fontes <ramonreisfontes@...il.com>
>
> Thanks,
> Miquèl