netdev - Re: [PATCH] mac802154_hwsim: define perm_extended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cye4qexa.fsf@bootlin.com>
Date: Wed, 26 Mar 2025 11:12:01 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Ramon Fontes <ramonreisfontes@...il.com>
Cc: davem@...emloft.net,  kuba@...nel.org,  pabeni@...hat.com,
  linux-wpan@...r.kernel.org,  alex.aring@...il.com,
  netdev@...r.kernel.org
Subject: Re: [PATCH] mac802154_hwsim: define perm_extended_addr initialization

Hello Ramon,

On 25/03/2025 at 13:53:12 -03, Ramon Fontes <ramonreisfontes@...il.com> wrote:

> This establishes an initialization method for perm_extended_addr, aligning it with the approach used in mac80211_hwsim.

You are now enforcing an (almost) static value, is that the intended
behaviour? If yes I would like a better explanation of why this is
relevant and how you picked eg. 0x02 as prefix to justify the change.

In general I am not opposed, even though I kind of liked the idea of
generating random addresses, especially since hwsim is not the only one
to do that and having a simulator that behaves like regular device
drivers actually makes sense IMO.

Also, please wrap the commit log.

> Signed-off-by: Ramon Fontes <ramonreisfontes@...il.com>

Thanks,
Miquèl