netdev - Re: [PATCH net-next] tc-tests: Update tc police action tests for tc buffer size rounding fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6231806-8666-4b07-982c-7061ca352b59@mojatatu.com>
Date: Wed, 26 Mar 2025 16:04:36 -0300
From: Pedro Tammela <pctammela@...atatu.com>
To: Jakub Kicinski <kuba@...nel.org>, Jamal Hadi Salim <jhs@...atatu.com>,
 Torben Nielsen <t8927095@...il.com>
Cc: Jonathan Lennox <jonathan.lennox42@...il.com>,
 Paolo Abeni <pabeni@...hat.com>, Jonathan Lennox <jonathan.lennox@....com>,
 David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
 Stephen Hemminger <stephen@...workplumber.org>,
 Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next] tc-tests: Update tc police action tests for tc
 buffer size rounding fixes.

On 26/03/2025 08:39, Jakub Kicinski wrote:
> On Tue, 11 Mar 2025 07:15:26 -0400 Jamal Hadi Salim wrote:
>>> On Tue, 11 Mar 2025 10:16:14 +0100 Paolo Abeni wrote:
>>>> AFAICS this fix will break the tests when running all version of
>>>> iproute2 except the upcoming one. I think this is not good enough; you
>>>> should detect the tc tool version and update expected output accordingly.
>>>>
>>>> If that is not possible, I think it would be better to simply revert the
>>>> TC commit.
>>>
>>> Alternatively since it's a regex match, maybe we could accept both?
>>>
>>> -        "matchPattern": "action order [0-9]*:  police 0x1 rate 7Mbit burst 1024Kb mtu 2Kb action reclassify",
>>> +        "matchPattern": "action order [0-9]*:  police 0x1 rate 7Mbit burst (1Mb|1024Kb) mtu 2Kb action reclassify",
>>>
>>> ? Not sure which option is most "correct" from TDC's perspective..
>>
>> It should work. Paolo's suggestion is also reasonable.
> 
> Sorry for the ping but where are we with this? TDC has been "red" for
> the last 3 weeks, would be really neat to get a clear run before we
> ship the net-next tree to Linus :(

Jonathan's issue is solved.
A new one popped in iproute-2:
https://web.git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=afbfd2f2b0a633d068990775f8e1b73b8ee83733

Changed the nat's "default" ip address from 0.0.0.0/32 to 0.0.0.0/0,
which makes tdc fail :)

https://github.com/p4tc-dev/tc-executor/blob/storage/artifacts/50205/1-tdc-sh/stdout#L2213