netdev - Re: [PATCH v4 net 0/3] udp: Fix two integer overflows when sk->sk_rcvbuf is close to INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250331182142.1108-1-kuniyu@amazon.com>
Date: Mon, 31 Mar 2025 11:21:34 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuba@...nel.org>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<horms@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH v4 net 0/3] udp: Fix two integer overflows when sk->sk_rcvbuf is close to INT_MAX.

From: Jakub Kicinski <kuba@...nel.org>
Date: Mon, 31 Mar 2025 06:51:09 -0700
> On Sat, 29 Mar 2025 11:05:10 -0700 Kuniyuki Iwashima wrote:
> > v4:
> >   * Patch 4
> >     * Wait RCU for at most 30 sec
> 
> The new test still doesn't pass
> 
> TAP version 13
> 1..1
> # timeout set to 3600
> # selftests: net: so_rcvbuf
> # 0.00 [+0.00] TAP version 13
> # 0.00 [+0.00] 1..2
> # 0.00 [+0.00] # Starting 2 tests from 2 test cases.
> # 0.00 [+0.00] #  RUN           so_rcvbuf.udp_ipv4.rmem_max ...
> # 0.00 [+0.00] # so_rcvbuf.c:151:rmem_max:Expected pages (35) == 0 (0)
> # 0.00 [+0.00] # rmem_max: Test terminated by assertion
> # 0.00 [+0.00] #          FAIL  so_rcvbuf.udp_ipv4.rmem_max
> # 0.00 [+0.00] not ok 1 so_rcvbuf.udp_ipv4.rmem_max
> # 0.01 [+0.00] #  RUN           so_rcvbuf.udp_ipv6.rmem_max ...
> # 0.01 [+0.00] # so_rcvbuf.c:151:rmem_max:Expected pages (35) == 0 (0)
> # 0.01 [+0.00] # rmem_max: Test terminated by assertion
> # 0.01 [+0.00] #          FAIL  so_rcvbuf.udp_ipv6.rmem_max
> # 0.01 [+0.00] not ok 2 so_rcvbuf.udp_ipv6.rmem_max
> # 0.01 [+0.00] # FAILED: 0 / 2 tests passed.
> # 0.01 [+0.00] # Totals: pass:0 fail:2 xfail:0 xpass:0 skip:0 error:0
> not ok 1 selftests: net: so_rcvbuf # exit=1
> 
> 
> Plus we also see failures in udpgso.sh

I forgot to update `size` when skb_condense() is called.

Without the change I saw the new test stuck at 1 page after
udpgso.sh, but with the change both passed.

Will post v5.

Thanks!