netdev - Re: [PATCH v1 net] rtnetlink: Use register_pernet_subsys() in rtnl_net_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250331182532.1523-1-kuniyu@amazon.com>
Date: Mon, 31 Mar 2025 11:25:27 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <horms@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH v1 net] rtnetlink: Use register_pernet_subsys() in rtnl_net_debug_init().

From: Simon Horman <horms@...nel.org>
Date: Mon, 31 Mar 2025 16:48:49 +0100
> On Fri, Mar 28, 2025 at 03:04:48PM -0700, Kuniyuki Iwashima wrote:
> > rtnl_net_debug_init() registers rtnl_net_debug_net_ops by
> > register_pernet_device() but calls unregister_pernet_subsys()
> > in case register_netdevice_notifier() fails.
> > 
> > It corrupts pernet_list because first_device is not updated
> > in unregister_pernet_device().
> 
> Hi Iwashima-san,
> 
> Maybe I am confused, but should the above line refer to
> unregister_pernet_subsys()?

Ah, exactly :)


> 
> And perhaps it would be yet clearer to say something like:
> 
> It corrupts pernet_list because first_device is not updated
> in register_pernet_device() but not unregister_pernet_subsys()?

Will rewrite in v2.

Thanks!