netdev - Re: [PATCH net-next v2 2/4] net/mlx5: Expose serial numbers in devlink info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6mrfruwwp35efgzjjvgqkvjzahsvki6b3sw6uozapl7o5nf6mu@z6t7s7qp6e76>
Date: Mon, 31 Mar 2025 15:06:18 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com, 
	andrew+netdev@...n.ch, horms@...nel.org, donald.hunter@...il.com, parav@...dia.com
Subject: Re: [PATCH net-next v2 2/4] net/mlx5: Expose serial numbers in
 devlink info

Tue, Mar 25, 2025 at 12:46:53PM +0100, kuba@...nel.org wrote:
>On Thu, 20 Mar 2025 09:59:45 +0100 Jiri Pirko wrote:
>> +	start = pci_vpd_find_ro_info_keyword(vpd_data, vpd_size,
>> +					     PCI_VPD_RO_KEYWORD_SERIALNO, &kw_len);
>> +	if (start >= 0) {
>> +		str = kstrndup(vpd_data + start, kw_len, GFP_KERNEL);
>> +		if (!str) {
>> +			err = -ENOMEM;
>> +			goto end;
>> +		}
>> +		end = strchrnul(str, ' ');
>> +		*end = '\0';
>> +		err = devlink_info_board_serial_number_put(req, str);
>> +		kfree(str);
>> +	}
>> +
>> +	start = pci_vpd_find_ro_info_keyword(vpd_data, vpd_size, "V3", &kw_len);
>> +	if (start >= 0) {
>> +		str = kstrndup(vpd_data + start, kw_len, GFP_KERNEL);
>> +		if (!str) {
>> +			err = -ENOMEM;
>> +			goto end;
>> +		}
>> +		err = devlink_info_serial_number_put(req, str);
>> +		kfree(str);
>> +	}
>
>I suppose you only expect one of the fields to be populated but 
>the code as is doesn't express that.

Nope. none or all could be populated, depends on what device exposes.