netdev - Re: [PATCH net-next v2 2/4] net/mlx5: Expose serial numbers in devlink info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250331092226.589edb9a@kernel.org>
Date: Mon, 31 Mar 2025 09:22:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com,
 andrew+netdev@...n.ch, horms@...nel.org, donald.hunter@...il.com,
 parav@...dia.com
Subject: Re: [PATCH net-next v2 2/4] net/mlx5: Expose serial numbers in
 devlink info

On Mon, 31 Mar 2025 15:06:18 +0200 Jiri Pirko wrote:
> >I suppose you only expect one of the fields to be populated but 
> >the code as is doesn't express that.  
> 
> Nope. none or all could be populated, depends on what device exposes.

Then you override the err in case first put fails.
But also having two serial numbers makes no sense.