netdev - Re: [PATCH net-next v2 2/4] net/mlx5: Expose serial numbers in devlink info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qt22pagi3weqc2mazctajndd5sej6zmvr3q4sq25r2ioe2qaow@parw3mavhvji>
Date: Tue, 1 Apr 2025 11:01:44 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com, 
	andrew+netdev@...n.ch, horms@...nel.org, donald.hunter@...il.com, parav@...dia.com
Subject: Re: [PATCH net-next v2 2/4] net/mlx5: Expose serial numbers in
 devlink info

Mon, Mar 31, 2025 at 06:22:26PM +0200, kuba@...nel.org wrote:
>On Mon, 31 Mar 2025 15:06:18 +0200 Jiri Pirko wrote:
>> >I suppose you only expect one of the fields to be populated but 
>> >the code as is doesn't express that.  
>> 
>> Nope. none or all could be populated, depends on what device exposes.
>
>Then you override the err in case first put fails.

Correct, will fix.


>But also having two serial numbers makes no sense.

They are serial number for different entity:
  serial_number e4397f872caeed218000846daa7d2f49
  board.serial_number MT2314XZ00YA

Why it does not make sense?