[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADXeF1H6-LdbZOsEdSnp+3k8xG-K4dqg2Pk58cDmpHBeCkdUSQ@mail.gmail.com>
Date: Tue, 1 Apr 2025 11:40:20 +0900
From: Yuyang Huang <yuyanghuang@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
donald.hunter@...il.com, jacob.e.keller@...el.com
Subject: Re: [PATCH net] netlink: specs: fix schema of rt_addr
Reviewed-by: Yuyang Huang <yuyanghuang@...gle.com>
On Tue, Apr 1, 2025 at 10:29 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> The spec is mis-formatted, schema validation says:
>
> Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']:
> {'minimum': 0, 'type': 'integer'}
>
> On instance['operations']['list'][3]['dump']['request']['value']:
> '58 - ifa-family'
>
> The ifa-family clearly wants to be part of an attribute list.
>
> Fixes: dfb0f7d9d979 ("doc/netlink: Add spec for rt addr messages")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: yuyanghuang@...gle.com
> CC: jacob.e.keller@...el.com
> ---
> Documentation/netlink/specs/rt_addr.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/netlink/specs/rt_addr.yaml b/Documentation/netlink/specs/rt_addr.yaml
> index 5dd5469044c7..3bc9b6f9087e 100644
> --- a/Documentation/netlink/specs/rt_addr.yaml
> +++ b/Documentation/netlink/specs/rt_addr.yaml
> @@ -187,6 +187,7 @@ protonum: 0
> dump:
> request:
> value: 58
> + attributes:
> - ifa-family
> reply:
> value: 58
> --
> 2.49.0
>
Powered by blists - more mailing lists