netdev - Re: [PATCH net-next 6/9] net: ethernet: ti: cpsw_ale: add cpsw_ale_policer_set/clr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5a47ca2-a64a-409f-a143-637699e316c7@kernel.org>
Date: Wed, 2 Apr 2025 15:37:25 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Siddharth Vadapalli <s-vadapalli@...com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>,
 danishanwar@...com, srk@...com, linux-omap@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 6/9] net: ethernet: ti: cpsw_ale: add
 cpsw_ale_policer_set/clr_entry()

On 25/03/2025 16:21, Jakub Kicinski wrote:
> On Wed, 19 Mar 2025 15:38:32 +0200 Roger Quadros wrote:
>> +/* FIXME: VLAN ID based flow routing not yet working, Only PCP matching for now
>> + *		u32 port_mask, unreg_mcast = 0;
>> + *
>> + *		port_mask = BIT(cfg->port_id) | ALE_PORT_HOST;
>> + *		if (!cfg->vid)
>> + *			unreg_mcast = port_mask;
>> + *		ale_idx = cpsw_ale_vlan_add_modify(ale, cfg->vid, port_mask,
>> + *				unreg_mcast, port_mask, 0);
>> + *		if (ale_idx < 0)
>> + *			return -ENOENT;
>> + *
>> + *		regmap_field_write(ale->fields[POL_OVLAN_INDEX], ale_idx);
>> + *		regmap_field_write(ale->fields[POL_OVLAN_MEN], 1);
>> + */
> 
> This commented out code is odd.
> Shouldn't you check if the user asked for ID match and return an error?

I think I'll drop the comment.

-- 
cheers,
-roger