netdev - Re: [RFC net-next 2/2] eth: bnxt: add support rx side device memory TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250402054616.4dc1c5b5@kernel.org>
Date: Wed, 2 Apr 2025 05:46:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, horms@...nel.org, michael.chan@...adcom.com,
 pavan.chebbi@...adcom.com, ilias.apalodimas@...aro.org, dw@...idwei.uk,
 netdev@...r.kernel.org, kuniyu@...zon.com, sdf@...ichev.me,
 aleksander.lobakin@...el.com
Subject: Re: [RFC net-next 2/2] eth: bnxt: add support rx side device memory
 TCP

On Wed, 2 Apr 2025 21:09:11 +0900 Taehee Yoo wrote:
> > Do we check if rx copybreak is enabled before allowing ZC to be enabled?
> > We can't copybreak with unreadable memory.  
> 
> For the bnxt driver, only the first page's data is copied by rx-copybreak.
> agg buffers are not affected by rx-copybreak.
> So I think it's okay.
> I tested rx-copybreak+devmem TCP, and it works well.
> 0 ~ 1024 rx-copybreak and from very small MTU to large MTU.

Ah, good point!