netdev - Re: [Patch net v2 01/11] sch_htb: make htb_qlen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407121431.GD395307@horms.kernel.org>
Date: Mon, 7 Apr 2025 13:14:31 +0100
From: Simon Horman <horms@...nel.org>
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, jiri@...nulli.us,
	victor@...atatu.com, Gerrard Tai <gerrard.tai@...rlabs.sg>
Subject: Re: [Patch net v2 01/11] sch_htb: make htb_qlen_notify() idempotent

On Thu, Apr 03, 2025 at 02:10:23PM -0700, Cong Wang wrote:
> htb_qlen_notify() always deactivates the HTB class and in fact could
> trigger a warning if it is already deactivated. Therefore, it is not
> idempotent and not friendly to its callers, like fq_codel_dequeue().
> 
> Let's make it idempotent to ease qdisc_tree_reduce_backlog() callers'
> life.
> 
> Reported-by: Gerrard Tai <gerrard.tai@...rlabs.sg>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>