netdev - Re: [Patch net v2 03/11] sch_hfsc: make hfsc_qlen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407121531.GF395307@horms.kernel.org>
Date: Mon, 7 Apr 2025 13:15:31 +0100
From: Simon Horman <horms@...nel.org>
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, jiri@...nulli.us,
	victor@...atatu.com, Gerrard Tai <gerrard.tai@...rlabs.sg>
Subject: Re: [Patch net v2 03/11] sch_hfsc: make hfsc_qlen_notify() idempotent

On Thu, Apr 03, 2025 at 02:10:25PM -0700, Cong Wang wrote:
> hfsc_qlen_notify() is not idempotent either and not friendly
> to its callers, like fq_codel_dequeue(). Let's make it idempotent
> to ease qdisc_tree_reduce_backlog() callers' life:
> 
> 1. update_vf() decreases cl->cl_nactive, so we can check whether it is
> non-zero before calling it.
> 
> 2. eltree_remove() always removes RB node cl->el_node, but we can use
>    RB_EMPTY_NODE() + RB_CLEAR_NODE() to make it safe.
> 
> Reported-by: Gerrard Tai <gerrard.tai@...rlabs.sg>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>