netdev - Re: [PATCH v1 net-next 2/4] net: Retire DCCP.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408173246.38170-1-kuniyu@amazon.com>
Date: Tue, 8 Apr 2025 10:31:20 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <pablo@...filter.org>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<horms@...nel.org>, <jmorris@...ei.org>, <kadlec@...filter.org>,
	<kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>,
	<ncardwell@...gle.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<paul@...l-moore.com>, <serge@...lyn.com>, <willemb@...gle.com>
Subject: Re: [PATCH v1 net-next 2/4] net: Retire DCCP.

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Tue, 8 Apr 2025 18:37:36 +0200
> Hi Kuniyuki,
> 
> On Mon, Apr 07, 2025 at 04:17:49PM -0700, Kuniyuki Iwashima wrote:
> > DCCP was orphaned in 2021 by commit 054c4610bd05 ("MAINTAINERS: dccp:
> > move Gerrit Renker to CREDITS"), which noted that the last maintainer
> > had been inactive for five years.
> > 
> > In recent years, it has become a playground for syzbot, and most changes
> > to DCCP have been odd bug fixes triggered by syzbot.  Apart from that,
> > the only changes have been driven by treewide or networking API updates
> > or adjustments related to TCP.
> > 
> > Thus, in 2023, we announced we would remove DCCP in 2025 via commit
> > b144fcaf46d4 ("dccp: Print deprecation notice.").
> > 
> > Since then, only one individual has contacted the netdev mailing list. [0]
> > 
> > There is ongoing research for Multipath DCCP.  The repository is hosted
> > on GitHub [1], and development is not taking place through the upstream
> > community.  While the repository is published under the GPLv2 license,
> > the scheduling part remains proprietary, with a LICENSE file [2] stating:
> > 
> >   "This is not Open Source software."
> >
> > The researcher mentioned a plan to address the licensing issue, upstream
> > the patches, and step up as a maintainer, but there has been no further
> > communication since then.
> > 
> > Maintaining DCCP for a decade without any real users has become a burden.
> >
> > Therefore, it's time to remove it.
> > 
> > Removing DCCP will also provide significant benefits to TCP.  It allows
> > us to freely reorganize the layout of struct inet_connection_sock, which
> > is currently shared with DCCP, and optimize it to reduce the number of
> > cachelines accessed in the TCP fast path.
> 
> Netfilter parses skbuffs, in that sense, it is a middlebox. Main
> concern on my side is that it could break rulesets, even for people
> that don't really see dccp traffic ever, ruleset could stop loading.
> 
> I would keep the netfilter bits aside by now, based on your netfilter
> updates, we can internally discuss how to phase out dccp support to
> get aligned with netdev maintainers, as it seems there is a wish to
> reduce debt in this front.

Fair enough.  I'll drop the netfilter stuff in v2.


> 
> Having said, this Netfilter does not rely on any of this socket
> structures, I think it should not be an impediment for your tree
> spring cleanup (IIRC we have no hard dependencies on CONFIG_DCCP).

Yes, actually I split changes for net/dccp, netfilter, and LSM
initially, and then, even without net/dccp, netfilter compiled
successfully if include/linux/dccp.h (dccp_hdr etc) was not removed.

Thanks!

---
pw-bot: cr