netdev - Re: [PATCH v1 net-next 3/4] net: Unexport shared functions for DCCP.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408162512.23a84b5e@kernel.org>
Date: Tue, 8 Apr 2025 16:25:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, David Ahern <dsahern@...nel.org>, "Neal Cardwell"
 <ncardwell@...gle.com>, Willem de Bruijn <willemb@...gle.com>, "Pablo Neira
 Ayuso" <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...filter.org>, Paul
 Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>, "Serge E.
 Hallyn" <serge@...lyn.com>, "Kuniyuki Iwashima" <kuni1840@...il.com>,
 <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 net-next 3/4] net: Unexport shared functions for
 DCCP.

On Mon, 7 Apr 2025 16:17:50 -0700 Kuniyuki Iwashima wrote:
> DCCP was removed, so many inet functions no longer need to
> be exported.
> 
> Let's unexport or use EXPORT_IPV6_MOD() for such functions.
> 
> sk_free_unlock_clone() is inlined in sk_clone_lock() as it's
> the only caller.

netfilter wants inet_twsk_put

ERROR: modpost: "inet_twsk_put" [net/ipv4/netfilter/nf_tproxy_ipv4.ko] undefined!
ERROR: modpost: "inet_twsk_put" [net/ipv6/netfilter/nf_tproxy_ipv6.ko] undefined!

allmodconfig builds seems to miss it :(
-- 
pw-bot: cr