netdev - Re: [PATCH v1 net-next 3/4] net: Unexport shared functions for DCCP.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250408235316.13501-1-kuniyu@amazon.com>
Date: Tue, 8 Apr 2025 16:53:02 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuba@...nel.org>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<horms@...nel.org>, <jmorris@...ei.org>, <kadlec@...filter.org>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <ncardwell@...gle.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <pablo@...filter.org>,
	<paul@...l-moore.com>, <serge@...lyn.com>, <willemb@...gle.com>
Subject: Re: [PATCH v1 net-next 3/4] net: Unexport shared functions for DCCP.

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue, 8 Apr 2025 16:25:12 -0700
> On Mon, 7 Apr 2025 16:17:50 -0700 Kuniyuki Iwashima wrote:
> > DCCP was removed, so many inet functions no longer need to
> > be exported.
> > 
> > Let's unexport or use EXPORT_IPV6_MOD() for such functions.
> > 
> > sk_free_unlock_clone() is inlined in sk_clone_lock() as it's
> > the only caller.
> 
> netfilter wants inet_twsk_put
> 
> ERROR: modpost: "inet_twsk_put" [net/ipv4/netfilter/nf_tproxy_ipv4.ko] undefined!
> ERROR: modpost: "inet_twsk_put" [net/ipv6/netfilter/nf_tproxy_ipv6.ko] undefined!
> 
> allmodconfig builds seems to miss it :(

Thanks for catching this!

I actually had ran allmodconfig but it couldn't catch it
because the error would be reproducible with IPV6=y.

I'll test allmodconfig + IPV6=y explicitly for v2.