netdev - Re: [PATCH net-next 1/5] net: stmmac: dwc-qos: remove tegra_eqos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c28aaa03-b2f7-44a5-9025-dfbfa0925ede@lunn.ch>
Date: Tue, 8 Apr 2025 20:56:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Jon Hunter <jonathanh@...dia.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-stm32@...md-mailman.stormreply.com,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Richard Cochran <richardcochran@...il.com>,
	Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH net-next 1/5] net: stmmac: dwc-qos: remove
 tegra_eqos_init()

On Mon, Apr 07, 2025 at 07:58:51PM +0100, Russell King (Oracle) wrote:
> tegra_eqos_init() initialises the 1US TIC counter for the EEE timers.
> However, the DWGMAC core is reset after this write, which clears
> this register to its default.
> 
> However, dwmac4_core_init() configures this register using the same
> clock, which happens after reset - thus this is the write which
> ensures that the register is correctly configured.
> 
> Therefore, tegra_eqos_init() is not required and is removed. This also
> means eqos->clk_slave can also be removed.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew