netdev - Re: [PATCH net-next 2/2] selftests: test_bridge_neigh_suppress: Test unicast ARP/NS with suppression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ee836f0-9d28-4e40-bcca-1b4eadd040f3@blackwall.org>
Date: Wed, 9 Apr 2025 13:33:37 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org
Cc: Ido Schimmel <idosch@...dia.com>, bridge@...ts.linux.dev,
 mlxsw@...dia.com, Amit Cohen <amcohen@...dia.com>
Subject: Re: [PATCH net-next 2/2] selftests: test_bridge_neigh_suppress: Test
 unicast ARP/NS with suppression

On 4/8/25 18:40, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> Add test cases to check that unicast ARP/NS packets are replied once, even
> if ARP/ND suppression is enabled.
> 
> Without the previous patch:
> $ ./test_bridge_neigh_suppress.sh
> ...
> Unicast ARP, per-port ARP suppression - VLAN 10
> -----------------------------------------------
> TEST: "neigh_suppress" is on                                        [ OK ]
> TEST: Unicast ARP, suppression on, h1 filter                        [FAIL]
> TEST: Unicast ARP, suppression on, h2 filter                        [ OK ]
> 
> Unicast ARP, per-port ARP suppression - VLAN 20
> -----------------------------------------------
> TEST: "neigh_suppress" is on                                        [ OK ]
> TEST: Unicast ARP, suppression on, h1 filter                        [FAIL]
> TEST: Unicast ARP, suppression on, h2 filter                        [ OK ]
> ...
> Unicast NS, per-port NS suppression - VLAN 10
> ---------------------------------------------
> TEST: "neigh_suppress" is on                                        [ OK ]
> TEST: Unicast NS, suppression on, h1 filter                         [FAIL]
> TEST: Unicast NS, suppression on, h2 filter                         [ OK ]
> 
> Unicast NS, per-port NS suppression - VLAN 20
> ---------------------------------------------
> TEST: "neigh_suppress" is on                                        [ OK ]
> TEST: Unicast NS, suppression on, h1 filter                         [FAIL]
> TEST: Unicast NS, suppression on, h2 filter                         [ OK ]
> ...
> Tests passed: 156
> Tests failed:   4
> 
> With the previous patch:
> $ ./test_bridge_neigh_suppress.sh
> ...
> Unicast ARP, per-port ARP suppression - VLAN 10
> -----------------------------------------------
> TEST: "neigh_suppress" is on                                        [ OK ]
> TEST: Unicast ARP, suppression on, h1 filter                        [ OK ]
> TEST: Unicast ARP, suppression on, h2 filter                        [ OK ]
> 
> Unicast ARP, per-port ARP suppression - VLAN 20
> -----------------------------------------------
> TEST: "neigh_suppress" is on                                        [ OK ]
> TEST: Unicast ARP, suppression on, h1 filter                        [ OK ]
> TEST: Unicast ARP, suppression on, h2 filter                        [ OK ]
> ...
> Unicast NS, per-port NS suppression - VLAN 10
> ---------------------------------------------
> TEST: "neigh_suppress" is on                                        [ OK ]
> TEST: Unicast NS, suppression on, h1 filter                         [ OK ]
> TEST: Unicast NS, suppression on, h2 filter                         [ OK ]
> 
> Unicast NS, per-port NS suppression - VLAN 20
> ---------------------------------------------
> TEST: "neigh_suppress" is on                                        [ OK ]
> TEST: Unicast NS, suppression on, h1 filter                         [ OK ]
> TEST: Unicast NS, suppression on, h2 filter                         [ OK ]
> ...
> Tests passed: 160
> Tests failed:   0
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>  .../net/test_bridge_neigh_suppress.sh         | 125 ++++++++++++++++++
>  1 file changed, 125 insertions(+)
> 

Thanks,
Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>