netdev - Re: [PATCH net-next 6/6] bonding: Fix multiple long standing offload races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6a3c15014a415b644c361f4678eebb0f1e64c45.camel@nvidia.com>
Date: Wed, 9 Apr 2025 14:33:37 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "liuhangbin@...il.com" <liuhangbin@...il.com>
CC: "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
	"bbhushan2@...vell.com" <bbhushan2@...vell.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "hkelam@...vell.com" <hkelam@...vell.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "jv@...sburgh.net"
	<jv@...sburgh.net>, "razor@...ckwall.org" <razor@...ckwall.org>,
	"herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, Leon Romanovsky <leonro@...dia.com>,
	"ayush.sawal@...lsio.com" <ayush.sawal@...lsio.com>, Jianbo Liu
	<jianbol@...dia.com>, "sbhatta@...vell.com" <sbhatta@...vell.com>,
	"horms@...nel.org" <horms@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	Tariq Toukan <tariqt@...dia.com>, Saeed Mahameed <saeedm@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"steffen.klassert@...unet.com" <steffen.klassert@...unet.com>,
	"gakula@...vell.com" <gakula@...vell.com>, "przemyslaw.kitszel@...el.com"
	<przemyslaw.kitszel@...el.com>, "louis.peens@...igine.com"
	<louis.peens@...igine.com>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "sgoutham@...vell.com"
	<sgoutham@...vell.com>
Subject: Re: [PATCH net-next 6/6] bonding: Fix multiple long standing offload
 races

On Tue, 2025-04-08 at 08:08 +0000, Hangbin Liu wrote:
> Hi Cosmin,
> 
> Thanks a lot for the fixes. With your patch applied. I see the
> bond_ipsec_del_sa() still has WARN_ON(xs->xso.real_dev != real_dev);
> 
> Do you think if we still has this possibility? If yes, should we do
> xdo_dev_state_delete() on xs->xso.real_dev or real_dev?

You are right, the WARN_ON doesn't make sense any more.
bond_ipsec_del_sa() can get the same treatment as bond_ipsec_free_sa(),
I'll do so in the next version.

Cosmin.