[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD4GDZxUtPXpKffzTeEgGP0c3cjPe03xZU3VpssQcHYQsZCpsA@mail.gmail.com>
Date: Wed, 9 Apr 2025 15:36:25 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jacob Keller <jacob.e.keller@...el.com>, davem@...emloft.net, netdev@...r.kernel.org,
edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
horms@...nel.org, yuyanghuang@...gle.com, sdf@...ichev.me, gnault@...hat.com,
nicolas.dichtel@...nd.com, petrm@...dia.com
Subject: Re: [PATCH net-next 01/13] netlink: specs: rename rtnetlink specs in
accordance with family name
On Wed, 9 Apr 2025 at 15:15, Jakub Kicinski <kuba@...nel.org> wrote:
>
> IOW I think that either we
> - accept the slight inconsistency with old families using _, or
> - accept the slight annoyance with all languages having to do s/-/_/
> when looking up family ID, or
> - accept the inconsistency with all name properties in new YAML spec
> being separated with - and just the family name always using _.
>
> :( I picked the first option, assuming the genl family names don't have
> much of a convention. Admittedly I don't know of any with dashes but
> some of them use capital letters :S
>
> LMK if you think we should pick differently. In my mind picking option
> 1 is prioritizing consistency of the spec language over the consistency
> of user experience. We can alleviate the annoyance of typing --family ..
> with bash completions?
That seems fair to me. FWIW, dashes seem more CLI friendly too. And
you make a good point that existing genl names really are all over the
place.
Donald.
Powered by blists - more mailing lists