netdev - Re: [PATCH net-next 10/15] ixgbe: extend .info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409073835.5d0e4018@kernel.org>
Date: Wed, 9 Apr 2025 07:38:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
Cc: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "davem@...emloft.net"
 <davem@...emloft.net>, "pabeni@...hat.com" <pabeni@...hat.com>, "Dumazet,
 Eric" <edumazet@...gle.com>, "andrew+netdev@...n.ch"
 <andrew+netdev@...n.ch>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "jiri@...nulli.us"
 <jiri@...nulli.us>, "horms@...nel.org" <horms@...nel.org>, "corbet@....net"
 <corbet@....net>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "Polchlopek, Mateusz" <mateusz.polchlopek@...el.com>, "R, Bharath"
 <bharath.r@...el.com>, "Mrozowicz, SlawomirX"
 <slawomirx.mrozowicz@...el.com>, "Kwapulinski, Piotr"
 <piotr.kwapulinski@...el.com>
Subject: Re: [PATCH net-next 10/15] ixgbe: extend .info_get with() stored
 versions

On Wed, 9 Apr 2025 10:50:34 +0000 Jagielski, Jedrzej wrote:
> >Just to be crystal clear -- could you share the outputs for dev info:
> > - before update
> > - after update, before reboot/reload
> > - after update, after activation (/reboot/reload)
> >?  
> 
> OK so this looks this way:

Not terrible, but FWIW my expectation (and how we use it at Meta [1])
is that stored will always be present. If there is no update pending
it will simply be equal to running. Otherwise it's unclear whether
we're missing stored because it's not supported or because there is 
no pending update.

But I guess it's not a huge deal if for some reason you can't achieve
this behavior, just make sure to document it in the driver devlink doc.

1:
https://docs.kernel.org/networking/devlink/devlink-flash.html#firmware-version-management