netdev - Re: [PATCH net-next v4 0/2] tcp: add a new TW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJi9+qn-QyrghvT5xZOvqi_FQX5iGeW3X0Ty=xRe9i2MA@mail.gmail.com>
Date: Wed, 9 Apr 2025 17:58:50 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jiayuan Chen <jiayuan.chen@...ux.dev>
Cc: kuba@...nel.org, mrpre@....com, "David S. Miller" <davem@...emloft.net>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, 
	Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	David Ahern <dsahern@...nel.org>, Steffen Klassert <steffen.klassert@...unet.com>, 
	Sabrina Dubroca <sd@...asysnail.net>, Antony Antony <antony.antony@...unet.com>, 
	Christian Hopps <chopps@...n.net>, netdev@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 0/2] tcp: add a new TW_PAWS drop reason

On Wed, Apr 9, 2025 at 1:27 PM Jiayuan Chen <jiayuan.chen@...ux.dev> wrote:
>
> Devices in the networking path, such as firewalls, NATs, or routers, which
> can perform SNAT or DNAT, use addresses from their own limited address
> pools to masquerade the source address during forwarding, causing PAWS
> verification to fail more easily under TW status.
>
> Currently, packet loss statistics for PAWS can only be viewed through MIB,
> which is a global metric and cannot be precisely obtained through tracing
> to get the specific 4-tuple of the dropped packet. In the past, we had to
> use kprobe ret to retrieve relevant skb information from
> tcp_timewait_state_process().
>
> We add a drop_reason pointer and a new counter.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !