netdev - Re: [PATCH net v1] octeon_ep_vf: Resolve netdevice usage count issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH-L+nPExSU1jEa7+RnC=LhRaAvdymGFyR8+8am2=_dQp2ZGXA@mail.gmail.com>
Date: Wed, 9 Apr 2025 21:29:00 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Sathesh B Edara <sedara@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, hgani@...vell.com, 
	vimleshk@...vell.com, Veerasenareddy Burru <vburru@...vell.com>, 
	Shinas Rasheed <srasheed@...vell.com>, Satananda Burla <sburla@...vell.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v1] octeon_ep_vf: Resolve netdevice usage count issue

On Wed, Apr 9, 2025 at 9:04 PM Sathesh B Edara <sedara@...vell.com> wrote:
>
> Address the netdevice usage count problem in the following scenarios:
> - When the interface is down
> - During transmit queue timeouts
> Additionally, ensure all queues are stopped when the interface is down.

Looks like 2 different fixes and better split it as two separate patches.

Also, please add Fixes tag for bug fix patches.
>
> Signed-off-by: Sathesh B Edara <sedara@...vell.com>
> ---
>  drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> index 18c922dd5fc6..f16b5930d414 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
> @@ -526,6 +526,7 @@ static int octep_vf_stop(struct net_device *netdev)
>         netdev_info(netdev, "Stopping the device ...\n");
>
>         /* Stop Tx from stack */
> +       netif_tx_stop_all_queues(netdev);
>         netif_carrier_off(netdev);
>         netif_tx_disable(netdev);

netif_tx_disable() will internally invoke netif_tx_stop_queue() for
all the Tx queues.
>
> @@ -819,7 +820,6 @@ static void octep_vf_tx_timeout_task(struct work_struct *work)
>                 octep_vf_open(netdev);
>         }
>         rtnl_unlock();
> -       netdev_put(netdev, NULL);
>  }
>
>  /**
> @@ -834,7 +834,6 @@ static void octep_vf_tx_timeout(struct net_device *netdev, unsigned int txqueue)
>  {
>         struct octep_vf_device *oct = netdev_priv(netdev);
>
> -       netdev_hold(netdev, NULL, GFP_ATOMIC);
>         schedule_work(&oct->tx_timeout_task);
>  }
>
> --
> 2.36.0
>
>


-- 
Regards,
Kalesh AP

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4226 bytes)