netdev - Re: [PATCH net-next v3 3/4] page_pool: Convert page_pool_recycle_stats to u64_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409161140.-k4iGuQe@linutronix.de>
Date: Wed, 9 Apr 2025 18:11:40 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Yunsheng Lin <linyunsheng@...wei.com>
Cc: linux-rdma@...r.kernel.org, linux-rt-devel@...ts.linux.dev,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Ilias Apalodimas <ilias.apalodimas@...aro.org>,
	Jakub Kicinski <kuba@...nel.org>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	Joe Damato <jdamato@...tly.com>, Leon Romanovsky <leon@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Saeed Mahameed <saeedm@...dia.com>,
	Simon Horman <horms@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH net-next v3 3/4] page_pool: Convert
 page_pool_recycle_stats to u64_stats_t.

On 2025-04-08 20:13:09 [+0800], Yunsheng Lin wrote:
> > index 9d958128a57cb..5215fd51a334a 100644
> > --- a/Documentation/networking/page_pool.rst
> > +++ b/Documentation/networking/page_pool.rst
> > @@ -181,11 +181,11 @@ Stats
> >  
> >  	#ifdef CONFIG_PAGE_POOL_STATS
> >  	/* retrieve stats */
> > -	struct page_pool_stats stats = { 0 };
> > +	struct page_pool_stats stats = { };
> >  	if (page_pool_get_stats(page_pool, &stats)) {
> >  		/* perhaps the driver reports statistics with ethool */
> > -		ethtool_print_allocation_stats(&stats.alloc_stats);
> > -		ethtool_print_recycle_stats(&stats.recycle_stats);
> > +		ethtool_print_allocation_stats(u64_stats_read(&stats.alloc_stats));
> > +		ethtool_print_recycle_stats(u64_stats_read(&stats.recycle_stats));
> 
> The above seems like an unnecessary change? as stats.alloc_stats and

Right. The ethtool_print_.*() don't exist either. Let me remove that.

> stats.recycle_stats are not really 'u64_stats_t' type.
> 
> Otherwise, LGTM.
> Reviewed-by: Yunsheng Lin <linyunsheng@...wei.com>

Sebastian