netdev - Re: [PATCH net-next v3 0/4] page_pool: Convert stats to u64_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250408185636.4adc61fb@kernel.org>
Date: Tue, 8 Apr 2025 18:56:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-rt-devel@...ts.linux.dev, netdev@...r.kernel.org, "David S.
 Miller" <davem@...emloft.net>, Andrew Lunn <andrew+netdev@...n.ch>, Eric
 Dumazet <edumazet@...gle.com>, Ilias Apalodimas
 <ilias.apalodimas@...aro.org>, Jesper Dangaard Brouer <hawk@...nel.org>,
 Joe Damato <jdamato@...tly.com>, Paolo Abeni <pabeni@...hat.com>, Saeed
 Mahameed <saeedm@...dia.com>, Simon Horman <horms@...nel.org>, Tariq Toukan
 <tariqt@...dia.com>, Thomas Gleixner <tglx@...utronix.de>, Yunsheng Lin
 <linyunsheng@...wei.com>
Subject: Re: [PATCH net-next v3 0/4] page_pool: Convert stats to
 u64_stats_t.

On Tue,  8 Apr 2025 12:59:17 +0200 Sebastian Andrzej Siewior wrote:
> I don't know if it is ensured that only *one* update can happen because
> the stats are per-CPU and per NAPI device. But there will be now a
> warning on 32bit if this is really attempted in preemptible context.

I think recycling may happen in preemptible context, and from BH.
Have you tried to test?
The net.core.skb_defer_max sysctl may mask it for TCP traffic.