netdev - Re: [PATCH net-next 01/13] netlink: specs: rename rtnetlink specs in accordance with family name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92cc7b8f-6f9c-4f7a-99f0-5ea4f7e3d288@intel.com>
Date: Tue, 8 Apr 2025 21:49:06 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <donald.hunter@...il.com>,
	<yuyanghuang@...gle.com>, <sdf@...ichev.me>, <gnault@...hat.com>,
	<nicolas.dichtel@...nd.com>, <petrm@...dia.com>
Subject: Re: [PATCH net-next 01/13] netlink: specs: rename rtnetlink specs in
 accordance with family name



On 4/8/2025 5:03 PM, Jakub Kicinski wrote:
> The rtnetlink family names are set to rt-$name within the YAML
> but the files are called rt_$name. C codegen assumes that the
> generated file name will match the family. We could replace
> dashes with underscores in the codegen but making sure the
> family name matches the spec name may be more generally useful.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
+1 to being more useful to have the family name match the spec name, I
agree.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>